Skip to content

Refactoring exceptions #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 20, 2020
Merged

Refactoring exceptions #28

merged 5 commits into from
Jul 20, 2020
+46 −113

Conversation

fish-ball
Copy link
Contributor

  1. Refacter the throw sentence to use specific error class newly defined in python-wechaty-puppet, rather than raw Exception.
  2. Refacter the puppet_stub from field to property which automatically raises error when private field _puppet_stub is set, so we don't have to check whether puppet_stub is None or throws an error each time we use in a single method call.

fish-ball added 3 commits July 19, 2020 18:31
@fish-ball
Refactoring exception classes raised
25fa325
@fish-ball
Merge branch 'master' of https://github.com/wechaty/python-wechaty-pu…
8c913da 
…ppet-hostie into refactoring-exceptions
@fish-ball
upgrade VESION to 0.2.11

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
c7bd334
@fish-ball fish-ball requested a review from a team as a code owner July 19, 2020 12:29
fish-ball added 2 commits July 19, 2020 20:30
@fish-ball
remove a redundant puppet_stub null check case

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
bc55562
@fish-ball
fix type checking for wechaty_puppet.exceptions import

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
3caa47e
wj-Mcat
wj-Mcat approved these changes Jul 20, 2020
View reviewed changes
Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Jul 20, 2020

It's greate to add wechaty exception support.

@fish-ball fish-ball merged commit e3297ae into wechaty:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wj-Mcat wj-Mcat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fish-ball @wj-Mcat