Skip to content

fix time_stamp bug in message #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from Aug 27, 2020
Merged

fix time_stamp bug in message #124

merged 7 commits into from Aug 27, 2020

Conversation

ghost
Copy link

@ghost ghost commented Aug 15, 2020

No description provided.

@ghost ghost self-requested a review as a code owner August 15, 2020 10:01
@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 15, 2020

Thanks for fixing this bug, please bump the VERSION file to trigger the devops flow.

@ghost
Copy link
Author

ghost commented Aug 16, 2020

Thanks for fixing this bug, please bump the VERSION file to trigger the devops flow.

how to do that?

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 16, 2020

The latest version in VERSION file is 0.6.8, so you should change the version to 0.6.9 and commit it.

@huan
Copy link
Member

huan commented Aug 16, 2020

Link to wechaty/PMC#16

wj-Mcat
wj-Mcat previously approved these changes Aug 18, 2020
Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 19, 2020

@huan CLA license checking seems wrong. refer to licence/cla — Waiting for status to be reported, you can ReCheck Prs at cla-assistant.

@huan
Copy link
Member

huan commented Aug 19, 2020

It seems that the CLA has no response for this PR, could you please push a new commit to see if it can be triggered?

@wj-Mcat
Copy link
Collaborator

wj-Mcat commented Aug 20, 2020

It seems that the CLA has no response for this PR, could you please push a new commit to see if it can be triggered?

@exctech you can update the VERSION file to trigger license/cla. Waiting for your new commit.

Copy link
Collaborator

@wj-Mcat wj-Mcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wj-Mcat wj-Mcat merged commit e11ddc3 into wechaty:master Aug 27, 2020
@lijiarui
Copy link
Member

@exctech Congratulations! 🎉 🎉 🎉

You become a wechaty contributor successfully! 👏 👏 👏

Please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants