Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Fixed FriendshipType enum typo #1620

Merged
merged 2 commits into from
Oct 10, 2018
Merged

docs: Fixed FriendshipType enum typo #1620

merged 2 commits into from
Oct 10, 2018

Conversation

Gcaufy
Copy link
Contributor

@Gcaufy Gcaufy commented Oct 10, 2018

I'm submitting a...

[ ] Bug Fix
[ ] Feature
[x] Other (Documentation fixing)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

According the code: https://github.com/Chatie/wechaty-puppet/blob/master/src/schemas/friendship.ts#L1

Those enum should be lowercase.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@Gcaufy Gcaufy requested a review from lijiarui as a code owner October 10, 2018 07:20
@lijiarui
Copy link
Member

Thanks!

@huan huan merged commit 8ebd1e9 into wechaty:master Oct 10, 2018
@huan
Copy link
Member

huan commented Oct 10, 2018

Good catch, and thanks you very much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lijiarui lijiarui lijiarui approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gcaufy @lijiarui @huan