Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement toContact() method #1868

Merged
merged 3 commits into from
Oct 31, 2019
Merged

Implement toContact() method #1868

merged 3 commits into from
Oct 31, 2019

Conversation

su-chang
Copy link
Member

I'm submitting a...

[ ] Bug Fix
[x] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • Commit Messages follow the Conventional Commits pattern
    • A feature commit message is prefixed "feat:"
    • A bugfix commit message is prefixed "fix:"
  • Tests for the changes have been added

Description

please describe the changes that you are making

for features, please describe how to use the new feature

please include a reference to an existing issue, if applicable

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

@su-chang
Copy link
Member Author

related issue: #1855

@su-chang su-chang mentioned this pull request Oct 29, 2019
Closed
@huan huan requested a review from windmemory October 31, 2019 00:40
windmemory
windmemory requested changes Oct 31, 2019
View reviewed changes
Copy link
Member

@windmemory windmemory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, before we merge this, let's bump up the version of wechaty.

@CLAassistant
Copy link

CLAassistant commented Oct 31, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

windmemory
windmemory approved these changes Oct 31, 2019
View reviewed changes
Copy link
Member

@windmemory windmemory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! LGTM

@huan huan merged commit 36675b8 into wechaty:master Oct 31, 2019
@huan
Copy link
Member

huan commented Oct 31, 2019

@windmemory Thank you for approving this PR, and @su-chang Thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windmemory windmemory windmemory approved these changes

@huan huan huan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@su-chang @CLAassistant @huan @windmemory