Skip to content

Commit

Permalink
feat(weex): remove timer API from instance context
Browse files Browse the repository at this point in the history
  • Loading branch information
Hanks10100 committed May 20, 2021
1 parent 9cb3a47 commit 138df34
Showing 1 changed file with 1 addition and 46 deletions.
47 changes: 1 addition & 46 deletions src/platforms/weex/entry-framework.js
Original file line number Diff line number Diff line change
Expand Up @@ -25,12 +25,7 @@ export function createInstanceContext (
// Each instance has a independent `Vue` module instance
const Vue = instance.Vue = createVueModuleInstance(instanceId, weex)

// DEPRECATED
const timerAPIs = getInstanceTimer(instanceId, weex.requireModule)

const instanceContext = Object.assign({ Vue }, timerAPIs)
Object.freeze(instanceContext)
return instanceContext
return { Vue }
}

/**
Expand Down Expand Up @@ -145,43 +140,3 @@ function createVueModuleInstance (

return Vue
}

/**
* DEPRECATED
* Generate HTML5 Timer APIs. An important point is that the callback
* will be converted into callback id when sent to native. So the
* framework can make sure no side effect of the callback happened after
* an instance destroyed.
*/
function getInstanceTimer (
instanceId: string,
moduleGetter: Function
): Object {
const instance = instanceOptions[instanceId]
const timer = moduleGetter('timer')
const timerAPIs = {
setTimeout: (...args) => {
const handler = function () {
args[0](...args.slice(2))
}

timer.setTimeout(handler, args[1])
return instance.document.taskCenter.callbackManager.lastCallbackId.toString()
},
setInterval: (...args) => {
const handler = function () {
args[0](...args.slice(2))
}

timer.setInterval(handler, args[1])
return instance.document.taskCenter.callbackManager.lastCallbackId.toString()
},
clearTimeout: (n) => {
timer.clearTimeout(n)
},
clearInterval: (n) => {
timer.clearInterval(n)
}
}
return timerAPIs
}

0 comments on commit 138df34

Please sign in to comment.