Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance v1.2.0 #325

Merged
merged 7 commits into from
Mar 27, 2023
Merged

Conversation

fschmenger
Copy link
Collaborator

This branch contains a couple of minor fixes. For details please see the commit messages.

@chrismayer
Copy link
Collaborator

Thanks for this @fschmenger. Code looks good and I tested the changes in a customer app and in the the example apps and one thing I discovered: The map recording module shows an error Failed to start recording.

image

I am unsure how this is related to the changeset, but it worked on current master which I tested before.

@fschmenger
Copy link
Collaborator Author

Hi Christian,
thanks a lot for the review! I don't see anything in the changeset that could affect the map recorder. I've seen this happen, when one of your layers does not have the "crossOrigin": "anonymous" attribute set, which is also pointed out in the documentation. Does this error not happen before applying the changeset?

@chrismayer
Copy link
Collaborator

chrismayer commented Mar 23, 2023

I gave it another shot and it is related to the active layer set on the map. When activating the Tiled WMS layer in the demo apps the module won't work (even wont work anymore, if the layer is deactivated). Totally unrelated to this changeset.

So this is good to go. Feel free to merge. Thanks again!

…or both "ahocevar-wms" and "ahocevar-imagewms" layers, to make map recording work properly.
@fschmenger
Copy link
Collaborator Author

Hi Christian,
it seems that both ahocevar layers are no longer CORS enabled. It used to work, as a quick search yielded 80f2167 . Nevertheless maintenance is a good anchor to address such problems, so I ammended the fix.
Could you give it a quick a verification? Then feel free to merge.

@chrismayer
Copy link
Collaborator

Thanks for the additional fix regarding the MapRecorder. I can confirm that it works now.

Please merge.

@fschmenger fschmenger merged commit cc74640 into wegue-oss:master Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants