fix init with method params

weibocom · Dec 22, 2023 · c669f3c · c669f3c
1 parent 5902191
commit c669f3c
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/core/url.go b/core/url.go
@@ -178,7 +178,7 @@ func (u *URL) hasMethodParams() bool {
 				if strings.Contains(k, defaultMethodParamsSubStr) {
 					v = "t"
 					u.hasMethodParamsCache.Store("t")
-					break
+					return true
 				}
 			}
 		}

diff --git a/core/url_test.go b/core/url_test.go
@@ -198,6 +198,11 @@ func TestIntParamCache(t *testing.T) {
 	v = url.GetMethodIntValue("method", "desc", "testKey", 10)
 	assert.Equal(t, int64(100), v)
 	url.ClearCachedInfo()
+	// test init with method params
+	assert.True(t, url.hasMethodParams())
+	// test init without method params
+	delete(url.Parameters, "method(desc).testKey")
+	url.ClearCachedInfo()
 	assert.False(t, url.hasMethodParams())
 
 	// test GetPortStr
-Original file line number
+Diff line change
@@ Expand Up / @@ -178,7 +178,7 @@ func (u *URL) hasMethodParams() bool { @@
     				if strings.Contains(k, defaultMethodParamsSubStr) {
     					v = "t"
     					u.hasMethodParamsCache.Store("t")
-    					break
+    					return true
     				}
     			}
     		}
@@ Expand Down @@