Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix client call with multi params #51

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fix client call with multi params #51

merged 1 commit into from
Oct 31, 2024

Conversation

rayzhang0603
Copy link
Contributor

fix client call with multi params

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 20.68966% with 23 lines in your changes missing coverage. Please review.

Project coverage is 3.30%. Comparing base (1f69666) to head (7ccfa35).

Files with missing lines Patch % Lines
src/Motan/Endpointer.php 0.00% 18 Missing ⚠️
src/Motan/Transport/Connection.php 0.00% 3 Missing ⚠️
src/Motan/Client.php 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               dev     #51      +/-   ##
==========================================
+ Coverage     3.19%   3.30%   +0.11%     
- Complexity     586     587       +1     
==========================================
  Files           30      30              
  Lines         1630    1632       +2     
==========================================
+ Hits            52      54       +2     
  Misses        1578    1578              
Flag Coverage Δ
unittests 3.30% <20.68%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@cocowh cocowh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayzhang0603 rayzhang0603 merged commit 6c024ac into dev Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants