Patch 3 #1
Closed
Patch 3 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated ZF submodule to c85c45a of weierophinney/feature/view-layer - Updated configuration to utilize new view layer - Updated controllers to return View Models - Updated Application\Module to only configure necessary view helpers - Removed Application\View\Listener; no longer necessary
- due to feature/view-layer being only on that fork
- Since bootstrap now contains configuration for template path stack, can simply path "paths" parameter
- names of templates should not include file suffix - corrected parameter names for exception, no route strategies
- Branch contained fixes for exception/no route (404) reporting
- Removed unneeded aliases - Removed obsolete classmap entries - Updated ZF2 library to latest feature/view-layer
- Includes fix for routing failures
- Updated to include ability to cast assoc arrays to ViewModels
- Updated to rev 34bc3d7
- Updated to rev 878cb78
- Updated ZF2 to rev db6a6e3 - Modified configuration to use AggregateResolver
- Updated to rev ff26301 of weierophinney/feature/view-layer
- Updated to rev df03479 of weierophinney/feature/view-layer
Removed redundant argument being passed
- Updated to rev 77430c4 of weierophinney/feature/view-layer
- Updated to rev 84eea97 of weierophinney/feature/view-layer
- Updated to rev e23c369 of weierophinney/feature/view-layer
- Updated to rev da0ff71 of weierophinney/feature/view-layer
- Updated to rev 3baed8c of weierophinney/feature/view-layer
- Updated to rev f1a3ddf of weierophinney/feature/view-layer
- Updated to rev 1087833 of weierophinney/feature/view-layer
- Updated to rev 30a545b of weierophinney/feature/view-layer
The definition originally was in Mvc\Bootstrap::setLocator. It would be better to leave the definition in Bootstrap, and simply set a "preference" value in the config, but the definition *appears* to override the preference settings.
- Updated to rev ef1e8b1 of weierophinney/feature/view-layer
- Updated to rev 80d3f32 of weierophinney/feature/view-layer
- Updated to rev 332d169 of weierophinney/feature/view-layer
- Updated to rev ab750ae of weierophinney/feature/view-layer
Conflicts: vendor/ZendFramework
Added vendor/ dir.
Added an error to index when vendor/autoload.php could not be found.
Updated composer.
Added composer autoloading to Skeleton and updated Module.php to reflect.
…load-files Remove autoload files that are no longer needed.
Added config/autoload/*local.php to gitignore
Per @Ocramius, composer.lock is useful for deployment. We don't need it included with the skeleton since it is generated on the first install, however we likely do not want it to be ignored from version control, since it carries the tested versions of the dependencies from development to production in the deployment process.
Since we no longer include the classmap file.
…ixes Hotfix/composer fixes
Removing unused stat call and reducing complexity of index.php
|
github borked, was trying to update README.md for canonical repo.. |
weierophinney
pushed a commit
that referenced
this pull request
Apr 18, 2016
When using the ZendSkeletonApp along with ZFTool, the translator throws a fatal error due to an alias clash.
ZFTool registers the translator as a factory service, and with the skeleton app aliasing "translator", it throws:
```
Uncaught exception 'Zend\ServiceManager\Exception\InvalidServiceNameException' with message 'An alias by the name "translator" or "translator" already exists' in /Users/ptah/Sites/zf2SkeletonApp.dev/vendor/zendframework/zendframework/library/Zend/ServiceManager/ServiceManager.php:756
Stack trace:
#0 /Users/ptah/Sites/zf2SkeletonApp.dev/vendor/zendframework/zendframework/library/Zend/ServiceManager/Config.php(150): Zend\ServiceManager\ServiceManager->setAlias('translator', 'MvcTranslator')
#1 /Users/ptah/Sites/zf2SkeletonApp.dev/vendor/zendframework/zendframework/library/Zend/ModuleManager/Listener/ServiceListener.php(223): Zend\ServiceManager\Config->configureServiceManager(Object(Zend\ServiceManager\ServiceManager))
#2 [internal function]: Zend\ModuleManager\Listener\ServiceListener->onLoadModulesPost(Object(Zend\ModuleManager\ModuleEvent))
#3 /Users/ptah/Sites/zf2SkeletonApp.dev/vendor/zendframework/zendframework/library/Zend/EventManager/EventManager.php(468): call_user_func(Array, Object(Zend\ModuleManager\ModuleEvent))
#4 /Users/ptah/Sites/zf2 in /Users/ptah/Sites/zf2SkeletonApp.dev/vendor/zendframework/zendframework/library/Zend/ServiceManager/ServiceManager.php on line 756
```
The fix is to register the translator as a factory service within the skeleton app so zf2 can have fun overriding config definitions :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
submodules removed, updated instructions to clone in zf2 by hand