Backport fixes #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -223,7 +223,7 @@ public function createInput($inputSpecification) | |||
| throw new Exception\RuntimeException(sprintf( | |||
| '%s "continue_if_empty" can only set to inputs of type "%s"', | |||
| __METHOD__, | |||
| __NAMESPACE__ . '\Input' | |||
| 'Zend\InputFilter\Input' | |||
There was a problem hiding this comment.
This change is unnecessary.
There was a problem hiding this comment.
See my reasons on the PR description.
Also match the original value (after squash less changes in the diff)
|
Almost all imports added are used for typehint comments Maintain them make the code more close to master and less conflicts in future backports. |
|
squashed with other backported changes on my local copy; will push shortly, after fixing the changelog. |
|
👏 👏 |
|
Changes are pushed; please verify! |
|
RC1: a9daa50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid use NAMESPACE. For future automatizations will be more easy replace the whole FQCN than guess the result of concat
https://travis-ci.org/Maks3w/zend-inputfilter/builds/79452868