Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix DatashaderRasterizer to allow N:1 instead of just 1:1 #98

Merged
merged 2 commits into from
May 14, 2023
Merged

🐛 Fix DatashaderRasterizer to allow N:1 instead of just 1:1 #98

merged 2 commits into from
May 14, 2023

Commits on May 14, 2023

  1. 🐛 Fix DatashaderRasterizer to allow N:1 instead of just 1:1 

    Used to wrong boolean operator (should be and, not or) which meant DatashaderRasterizer didn't work when the vector_datapipe was length 1 and canvas_datapipe was length 2 or more. This prevents false errors like `ValueError: Unmatched lengths for the canvas datapipe (XarrayCanvasIterDataPipe) and vector datapipe (PyogrioReaderIterDataPipe). The vector datapipe's length (1) should either be (1) to allow for broadcasting, or match the canvas datapipe's length of (2)`.

Patches the bugfix at #39 from zen3geo v0.3.0. Also updated a unit test to use a 2:1 canvas:vector ratio to prevent regression.
    @weiji14
    weiji14 committed May 14, 2023
    Configuration menu
    Copy the full SHA
    9da2679 View commit details
    Browse the repository at this point in the history

  2. 📌 Temporarily pin numpy<1.24 to prevent AttributeError 

    The latest numpy=1.24 version installed via readthedocs is incompatible with datashader=0.14.4, resulting in an error like `AttributeError: module 'numpy' has no attribute 'warnings'`. This was reported in holoviz/datashader#1209 and fixed in holoviz/datashader#1176, but will need to wait for datashader>=0.14.5 to be released.
    @weiji14
    weiji14 committed May 14, 2023
    Configuration menu
    Copy the full SHA
    a5233e4 View commit details
    Browse the repository at this point in the history