Refine equipment list

[Defiect]

What feature would you like to see?

Currently, every variant of a piece of equipment is shown to the user, e.g. all 10 versions of the Crystal Bow.

At least one unequippable item has been spotted in the list as well: Orange Goblin Mail (perhaps due to its Wear option)

Cutting down on the size of the result list by removing redundant variants of items will be a large improvement to usability.

Evidence

No response

[SuperNerdEric]

Here's a few that have been bothering me

• Broken versions
• Locked versions
• Uncharged versions
• Inactive versions
• (Last Man Standing)

The imbued versions should probably get collapsed into a single version

• Emir's Arena / Nightmare Zone / Soul Wars
• Recolored slayer helmet variants

[jayktaylor]

I've pushed a commit to remove broken versions and LMS versions of items, but I'm wondering if removing locked versions etc might make it harder to implement #32 in the future.

[Nightfirecat]

Discussed this in Discord a bit, but wanted to bring it up here also--it's possible that leaning on the client's ItemVariationMapping utilities could help a bit there. @LlemonDuck noted that there are some cases where it wouldn't work (eg. all Salve amulets map to the base non-imbued, non-enhanced version) but I think that could be either worked around by special-casing it, or fixed upstream if RuneLite decides it would improve the mapping.

[jayktaylor]

I've introduced EquipmentAliases.ts, where variants of items are mapped from item ID -> main variant item ID. This should help us in the future if we add RuneLite integration.

[SuperNerdEric]

Don't forget to also do Recolored slayer helmet variants

[lezed1]

I've handled lots of cases, but I think there will be a long tail of items to add. I'll try to handle all the cases mentioned in this issue. Please comment with more cases if you spot anything! I wanted to write down the remaining things I know about:

Colored goblin mail: These are equipable during the Land of the Goblins quest! I don't have a strong opinion here, but I think we should keep these since they are sometimes equipable.

Equipment with charges: We should choose a value to be the primary version and alias the rest. Maybe #1 (monospace to avoid linking to a github issue) since they all have it? We should also check for "#Full" and "#New" since those appear on the Crystal bow (i).

Equipment that can be uncharged: These should only be aliased if stats match exactly. This is kinda a dumb example, but if a person is manual casting a spell while holding a Toxic staff of the dead, the DPS is charged based on if the staff is charged.

Inactive: I'd want to double check this and add a rule to alias only if stats match exactly.

[jayktaylor]

Further pruning implemented in 5644804

[jayktaylor]

as of 318827c, pruning is now done when we're showing the list of equipment to the user. the calculator supports all items so that integration with RuneLite etc isn't odd

[Grizzlea]

Adding to the list: trimmed pieces .

Amulet of glory for example lists lists all variations of # of charges & trimmed vs untrimmed.