Remove unnecessary list comprehensions (#75)

weiwei · Dec 30, 2021 · 232c21a · 232c21a
1 parent ae78dd6
commit 232c21a
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/junitparser/junitparser.py b/junitparser/junitparser.py
@@ -158,7 +158,7 @@ def __repr__(self):
         keys = sorted(self._elem.attrib.keys())
         if keys:
             attrs_str = " ".join(
-                ['%s="%s"' % (key, self._elem.attrib[key]) for key in keys]
+                '%s="%s"' % (key, self._elem.attrib[key]) for key in keys
             )
             return """<Element '%s' %s>""" % (tag, attrs_str)
 
@@ -364,11 +364,11 @@ def __init__(self, name=None):
     def __iter__(self):
         return itertools.chain(
             super(TestSuite, self).iterchildren(TestCase),
-            [
+            (
                 case
                 for suite in super(TestSuite, self).iterchildren(TestSuite)
                 for case in suite
-            ],
+            ),
         )
 
     def __len__(self):
@@ -383,7 +383,7 @@ def props_eq(props1, props2):
             props1.sort(key=lambda x: x.name)
             props2.sort(key=lambda x: x.name)
             zipped = zip(props1, props2)
-            return all([x == y for x, y in zipped])
+            return all(x == y for x, y in zipped)
 
         return (
             self.name == other.name