Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade aws-sdk to v3 #13

Merged
merged 1 commit into from
Jun 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ prune:

package:
mkdir -p bin && rm -rf bin/*
npx pkg -c package.json --out-path bin src/index.js
npx -y pkg -t node16-linux-x64,node16-macos-x64,node16-win-x64 -c package.json --out-path bin src/index.js
bzip2 -k bin/*

release:
Expand Down
51 changes: 51 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -168,3 +168,54 @@ resources:
Identifiers:
- "s3://your-bucket/"
```

## Regression Test:
- validate
- validate config file with settings

```bash
BUILD_NUMBER=123 bin/aws-emr-runner-macos validate -f samples/enrichment-pipeline.yml -s samples/enrichment-pipeline.settings.yml
```

- validate config file without settings

```bash
BUILD_NUMBER=123 bin/aws-emr-runner-macos validate -f samples/enrichment-pipeline.yml
```

- resources
- create resource stack

```bash
BUILD_NUMBER=123 bin/aws-emr-runner-macos resources -f samples/enrichment-pipeline.yml -s samples/enrichment-pipeline.settings.yml
```

- delete resource stack

```bash
BUILD_NUMBER=123 bin/aws-emr-runner-macos delete-resources -f samples/enrichment-pipeline.yml -s samples/enrichment-pipeline.settings.yml
```

- cluster
- start cluster

```bash
BUILD_NUMBER=123 bin/aws-emr-runner-macos start-cluster -f samples/enrichment-pipeline.yml -s samples/enrichment-pipeline.settings.yml
```

- delete cluster

```bash
BUILD_NUMBER=123 bin/aws-emr-runner-macos terminate-cluster -f samples/enrichment-pipeline.yml -s samples/enrichment-pipeline.settings.yml --cluster-id <id>
```

- auto delete cluster
- run-step
- run spark step on cluster
- run
- wait for complete successfully
- wait for cancelled steps and fail

## TODO:
- Auto delete resource stack if can't updated
Failed to create cloudformation changeset for 'sample-spark-application-resources-prod', caused by ValidationError: Stack:arn:aws:cloudformation:ap-southeast-2:807579936170:stack/sample-spark-application-resources-prod/91895dd0-03a5-11ee-a3e7-02dee24aa130 is in ROLLBACK_COMPLETE state and can not be updated.
Loading