Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSI-301): bump locar to version 0.4.2 #380

Merged
merged 2 commits into from
Oct 30, 2024
Merged

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Oct 29, 2024

feat(CSI-300): change Makefile to use docker buildx

  • Updated Makefile to use docker buildx build instead of docker build

feat(CSI-300): change Dockerfile to use TARGETOS, TARGETARCH, LOCAR_VERSION, KUBECTL_VERSION

  • Added ARG instructions for KUBECTL_VERSION, TARGETARCH, TARGETOS, and LOCAR_VERSION
  • Updated Go build command to use TARGETOS and TARGETARCH
  • Changed kubectl image to use dynamic KUBECTL_VERSION
  • Replaced hardcoded locar download with a more flexible approach using LOCAR_VERSION, TARGETOS, and TARGETARCH
  • Moved locar binary copy from ADD instruction to COPY from go-builder stage

Copy link

graphite-app bot commented Oct 29, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (10/29/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

Copy link
Collaborator Author

sergeyberezansky commented Oct 30, 2024

Merge activity

  • Oct 30, 3:26 AM EDT: A user started a stack merge that includes this pull request via Graphite.
  • Oct 30, 3:27 AM EDT: Graphite couldn't merge this PR because it failed optional checks and "ignore optional checks" was not selected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant