-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CSI-308): add ReadWriteOncePod, ReadonlyOncePod support #397
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14656445 | Triggered | Generic Password | 3e19260 | pkg/wekafs/apiclient/apiclient_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (11/26/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
fa3c583
to
899b529
Compare
ad77fa7
to
6387fcc
Compare
899b529
to
f5c0421
Compare
6387fcc
to
2624296
Compare
c7ac771
to
05bc03c
Compare
2624296
to
9a097d9
Compare
05bc03c
to
06740fb
Compare
9a097d9
to
67117fa
Compare
06740fb
to
9c23145
Compare
67117fa
to
c964819
Compare
…ESSIBILITY_CONSTRAINTS
c964819
to
c229f89
Compare
ca91074
to
11ac1ec
Compare
dfbf883
to
4ec1e24
Compare
6e7c720
to
469bbea
Compare
tests: add several unittests for apiClient utilities
feat(CSI-308): add a DB directory to nodeserver daemonset
feat(CSI-308): add ControllerServiceCapability_RPC_SINGLE_NODE_MULTI_WRITER
feat(CSI-308): add identityserver PluginCapability_Service_VOLUME_ACCESSIBILITY_CONSTRAINTS
feat(CSI-308): modify DB path to /tmp dir
feat(CSI-308): implement database and sqlite3 backing
feat(CSI-308): implement node.GetNodeBootId
feat(CSI-308): implement SINGLE_NODE_* capability checking on NodePublishVolume
feat(CSI-308): add tests for NodeServer.ensurePublishingIsAllowed()