-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CSI-308): add support for ReadWriteOncePod, ReadOnlyOncePod #399
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
14656445 | Triggered | Generic Password | 3e19260 | pkg/wekafs/apiclient/apiclient_test.go | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Graphite Automations"Request reviewers once CI passes" took an action on this PR • (11/27/24)1 reviewer was added to this PR based on Sergey Berezansky's automation. |
dba1bcf
to
ee03f00
Compare
TL;DR
Added support for ReadWriteOncePod volumes, volume accessibility constraints, and enhanced test coverage for API client functionality.
What changed?
How to test?
go test ./pkg/wekafs/apiclient -v
Why make this change?