Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(CSI-308): add support for ReadWriteOncePod, ReadOnlyOncePod #399

Merged
merged 7 commits into from
Nov 27, 2024

Conversation

sergeyberezansky
Copy link
Collaborator

@sergeyberezansky sergeyberezansky commented Nov 27, 2024

TL;DR

Added support for ReadWriteOncePod volumes, volume accessibility constraints, and enhanced test coverage for API client functionality.

What changed?

  • Added ReadWriteOncePod support through SINGLE_NODE_MULTI_WRITER capability
  • Enabled volume accessibility constraints in plugin capabilities
  • Added comprehensive test coverage for API client functions including:
    • Payload masking
    • IPv4/IPv6 address validation
    • Hostname validation
    • Version compatibility mapping
  • Updated node server daemonset to handle boot ID and attachment database
  • Upgraded dependencies including CSI spec to v1.11.0 and Go to 1.22.7

How to test?

  1. Verify ReadWriteOncePod volumes can be created and mounted
  2. Run new test suites:
go test ./pkg/wekafs/apiclient -v
  1. Validate volume accessibility constraints are properly enforced
  2. Verify node server functionality with new boot ID and attachment database mounts

Why make this change?

  • Improves volume access control through ReadWriteOncePod support
  • Enhances system reliability with better topology awareness
  • Increases code quality and maintainability through expanded test coverage
  • Keeps dependencies current with latest stable versions

@graphite-app graphite-app bot requested a review from tigrawap November 27, 2024 10:13
Copy link
Collaborator Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

gitguardian bot commented Nov 27, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
14656445 Triggered Generic Password 3e19260 pkg/wekafs/apiclient/apiclient_test.go View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link

graphite-app bot commented Nov 27, 2024

Graphite Automations

"Request reviewers once CI passes" took an action on this PR • (11/27/24)

1 reviewer was added to this PR based on Sergey Berezansky's automation.

@sergeyberezansky sergeyberezansky merged commit 2f2d2eb into dev Nov 27, 2024
11 of 12 checks passed
@sergeyberezansky sergeyberezansky added enhancement New feature or request dependencies Pull requests that update a dependency file go documentation Improvements or additions to documentation labels Nov 27, 2024 — with Graphite App
@sergeyberezansky sergeyberezansky deleted the sergey/minimal-rwo-pod branch November 28, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant