Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapting local WordPress setup outside the project directory #513

Merged
merged 1 commit into from
Nov 16, 2019

Conversation

tnzk
Copy link
Contributor

@tnzk tnzk commented Feb 8, 2019

I'm going to use Wordmove to manage multiple sites, and have noticed that currently it rasies the error below if the local WordPress setup is outside the project directory:

Error: This does not seem to be a WordPress install. Pass --path=`path/to/wordpress` or run `wp core download`.

This PR is intended to solve this by always setting --path option to wp search-replace.

The path given to the options is retrieved by local_options[:wordpress_path]. Since it is where the local WordPress setup is located, I think setting it through --path does not harm any usage. Please correct me if not.

Related issue: #407

@alessandro-fazzi
Copy link
Member

I'll get on this one soon. I swear! 😃

Copy link
Member

@alessandro-fazzi alessandro-fazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I disappeared for a lot of months. I struggle for this, but here we are.

I'll merge this in master, than wait for another PR in review and I'll do a release with the 2 new features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants