More friendly error message for nonexistent env

[korkey128k]

Example of new error message

Using movefile from spec/fixtures/Movefile

Error message before:

$ bin/wordmove pull -d -s -e staging
gems/wordmove/lib/wordmove/deployer/base.rb:16:in `deployer_for': undefined method `[]' for nil:NilClass (NoMethodError)

Error message after:

$ bin/wordmove pull -d -s -e staging
gems/wordmove/lib/wordmove/movefile.rb:59:in `environment': No environment found for "staging". Available Environments: remote (Wordmove::UndefinedEnvironment)

[alessandro-fazzi]

Hey @korkey128k ! Thank you very much for you PR! It sounds really interesting.

I'd like to ask you two things:

1. You should update the description of the PR, explaining at least the effect it has with an example. Would be great to see the error message before and after, just to be able to understand the value w/o having to reproduce the behaviour by myself
2. what's your experience w/ ruby? I ask because test suite is red now and I don't know if I could help you with advises or directly with an intervention on the code. Knowing how much you're comfortable with the language will help me to help you ;)

Thanks so much in advance

[alessandro-fazzi]

I'd like to ask you two things:

• You should update the description of the PR, explaining at least the effect it has with an example. Would be great to see the error message before and after, just to be able to understand the value w/o having to reproduce the behaviour by myself
• what's your experience w/ ruby? I ask because test suite is red now and I don't know if I could help you with advises or directly with an intervention on the code. Knowing how much you're comfortable with the language will help me to help you ;)

[korkey128k]

Hey there,

• I'll work on a better description. I also want to move the exception to shorten the method length (as per rubocop). As far as the error in Travis, I'm not experiencing that in my local version, I'll see what I can do to reproduce it.
• I'm fairly comfortable in ruby, I believe I can fix the tests. I'll let you know if I need some assistance. 😀

[alessandro-fazzi]

Hey thanks for you iteration :)

This looks good to me 👍 Thanks a LOT

[alessandro-fazzi]

Waiting to merge just because I'd like to merge and release together with other PRs :)