Find Bean Classes In Inherited '@Inject'-ed Field #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manovotn
reviewed
Jan 8, 2021
There was a problem hiding this comment.
LGTM!
@philippkunz please create a tracking issue for this PR. Other than that, I have no objections.
philippkunz
changed the title
philippkunz
changed the title
philippkunz
force-pushed
the
inheritedinject
branch
from
13d1be4 to
b6adbf6
Compare
manovotn
approved these changes
Jan 8, 2021
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wondered why I had to specify
@AddBeanClasswith a class the same test inherited an injected field of that type. The bean class would have been found and added automatically if the injected field would have been on the test class itself as opposed to inherited. Weld also makes no such difference on whether injected fields are inherited or not so I figureweld-junitshould follow the same rules with@EnableAutoWeldmode as well.My guess is that there was an error in
ClassScanning's method formerly namedfindAnnotatedFieldsand now renamed tofindAnnotatedDeclaredFieldshaving calledgetDeclaredFieldswhich excludes inherited fields but the name of that method formerly namedfindAnnotatedFieldsdid not reflect this restriction and was missed where it is used inscanForRequiredBeanClasses.Producers, however, are not inherited, see https://docs.jboss.org/cdi/spec/2.0/cdi-spec.html#member_level_inheritance.