Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue #149; make method parameter injection work for parametrized types #152

Merged
merged 1 commit into from
Dec 5, 2022
Merged

fix issue #149; make method parameter injection work for parametrized types #152

merged 1 commit into from
Dec 5, 2022

Conversation

JHahnHRO
Copy link
Contributor

@JHahnHRO JHahnHRO commented Dec 4, 2022 •
edited by manovotn
Loading

Adds reproducer unit test and fixes #149

manovotn
manovotn approved these changes Dec 5, 2022
View reviewed changes
Copy link
Collaborator

@manovotn manovotn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out and sending a PR right away!

@manovotn manovotn merged commit 91b7b3d into weld:master Dec 5, 2022
@manovotn manovotn mentioned this pull request Dec 5, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manovotn manovotn manovotn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Method parameter injection fails with parametrized argument types
2 participants
@JHahnHRO @manovotn