Clarify that WeldInitiator.from() and WeldInitiator.of() should use the same variable scope #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he same variable scope
mkouba
approved these changes
Jan 30, 2024
manovotn
commented
Jan 30, 2024
| * | ||
| * @param weld | ||
| * @param weld instance of {@link Weld} used to create {@link WeldInitiator} | ||
| * @return a new WeldInitiator instance | ||
| */ | ||
| public static WeldInitiator of(Weld weld) { |
There was a problem hiding this comment.
In theory, this method shouldn't exhibit the problem as it returns WeldInitiator directly instead of returning a still-configurable Builder object but I added it here anyway for the sake of consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #167
While we cannot enforce this, we should still mention it as it's not very clear to users.
While keeping partly configured
Weldinstance in a static field, havingWeldInitiatorin non-static variable means that another layer of configuration is being applied to the sameWeldinstance for each test method in that given class.This leads to some unexpected and hard-to-debug scenarios.