Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not install polkit-gnome for blivet-gui #1347

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

vojtechtrefny
Copy link
Contributor

@vojtechtrefny vojtechtrefny commented Sep 19, 2023

blivet-gui-runtime doesn't depend on PolicyKit-authentication-agent only blivet-gui which is not on the installation images depends on polkit.


This was originally added by @AdamWill in 07f3e48 and I am not sure why, the blivet-gui-runtime package never depended on PolicyKit-authentication-agent. Maybe this was before the split into blivet-gui and blivet-gui-runtime.

$ sudo dnf repoquery --requires blivet-gui-runtime
Last metadata expiration check: 1:59:21 ago on Tue 19 Sep 2023 10:37:38 AM CEST.
/usr/bin/python3
gtk3
libreport
python(abi) = 3.11
python3
python3-blivet >= 1:3.3.0
python3-gobject
python3-pid

I did a quick test without this rule and the resulting image doesn't have any polkit agent installed, so I think it should be safe to remove this.

blivet-gui-runtime doesn't depend on PolicyKit-authentication-agent
only blivet-gui which is not on the installation images depends on
polkit.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6234503630

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.325%

Totals Coverage Status
Change from base Build 6115312116: 0.0%
Covered Lines: 1578
Relevant Lines: 3435

💛 - Coveralls

@AdamWill
Copy link
Contributor

You moved the requirement in 2.2.0-1:

* Fri Sep 11 2020 Vojtech Trefny <vtrefny@redhat.com> - 2.2.0-1
...
- Move the PolicyKit agent dependency from runtime to blivet-gui (vtrefny)

we must have had a build older than that in stable at the time I was working on that image oversize issue, for whatever branch it was on. Since the dep has been moved, I agree this should probably be fine.

Copy link
Contributor

@bcl bcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bcl bcl merged commit be26cbe into weldr:master Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants