Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

erofs: Change the erofs compression default to zstd #1435

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

bcl
Copy link
Contributor

@bcl bcl commented Nov 20, 2024

--rootfs-type erofs now uses:
zstd,8 -Ededupe,all-fragments -C 65536

unless overridden by the 'compression.erofs' section of a lorax config file.

--rootfs-type erofs now uses:
zstd,8 -Ededupe,all-fragments -C 65536

unless overridden by the 'compression.erofs' section of a lorax config
file.
@coveralls
Copy link

coveralls commented Nov 20, 2024

Pull Request Test Coverage Report for Build 11939805641

Details

  • 3 of 5 (60.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 43.507%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/pylorax/init.py 0 2 0.0%
Totals Coverage Status
Change from base Build 11445659534: 0.0%
Covered Lines: 1636
Relevant Lines: 3560

💛 - Coveralls

@bcl bcl merged commit 0571214 into weldr:master Nov 22, 2024
2 checks passed
@Conan-Kudo
Copy link
Contributor

What's the justification for -Ededupe,all-fragments -C 65536?

@bcl
Copy link
Contributor Author

bcl commented Nov 22, 2024

It produces somewhat smaller images. They're still not really close to squashfs yet, but it is an improvement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants