Set up some GHA CI #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisdral
commented
Mar 6, 2024
blockio-uring.cabal
Outdated
| @@ -1,4 +1,4 @@ | |||
| cabal-version: >=1.10 | |||
| cabal-version: 3.4 | |||
There was a problem hiding this comment.
@dcoutts did you pick >=1.10 for a reason, or can we use 3.4?
blockio-uring.cabal
Outdated
| build-depends: base, array, unix | ||
| build-depends: base >= 4.16 && < 4.20 | ||
| , array ^>= 0.5 | ||
| , unix ^>= 2.8 |
There was a problem hiding this comment.
If we want to support earlier versions of unix, then we'll have to add some CPP pragmas to each use of openFd, since it had a breaking change in unix-2.8.0.0
Since `unix-2.8.0.0`, `openFd` has one fewer argument. By constraining `unix` to `^>=2.8`, we don't have to add any CPP pragmas to make compilation work. If we do want to support `<=2.7`, then we can add the CPP pragmas later.
jorisdral
commented
Mar 6, 2024
There was a problem hiding this comment.
@dcoutts I formatted the file using cabal-fmt in the last commit. If you prefer I undo the formatting, then I can remove just the last commit. If you want to see just the changes to the cabal file sans formatting, then you can disable showing the last commit in the diff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow file is just a copy of IntersectMBO/lsm-tree@b0939ea to get some basic CI setup going. Since compilation was failing on some GHC versions, I did some maintenance on the cabal file and the benchmark code to get everything compiling.
Once this PR is merged, we can set the status checks to be required before merging into
main