Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Primitive types "failing test" #127

Merged
merged 5 commits into from
Sep 3, 2024
Merged

Primitive types "failing test" #127

merged 5 commits into from
Sep 3, 2024

Conversation

phadej
Copy link
Collaborator

@phadej phadej commented Sep 1, 2024

No description provided.

@phadej phadej changed the title Primitive types Primitive types "failing test" Sep 1, 2024
@phadej
Copy link
Collaborator Author

phadej commented Sep 1, 2024

The failing examples are interesting. We probably need to make the golden tests somehow machine dependent; their generation on development machines will become tricky though. On a "positive" side, we not have a first example where targets behave differently.

I'm not sure how to deal with these now. Suggestions?

@phadej
Copy link
Collaborator Author

phadej commented Sep 1, 2024

One option is to actually try do cross compilation stuff now (i.e. #10) . That would help move #83 / #98 forward too, as cross compilation flags were the ones we care about in ClangArgs AFAIU

@edsko
Copy link
Collaborator

edsko commented Sep 3, 2024

I'd certainly be in favour of starting to look at cross compilation now; it's a critical requirement, and taking it into account sooner rather than later may well help avoid some design mistakes.

@edsko edsko merged commit cabb7ec into main Sep 3, 2024
7 checks passed
@edsko edsko deleted the primitive-types branch September 3, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants