Introduce clang_getCursorKind
#150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using `clang_getCursorType` to determine what kind of AST element we were dealing with, but that's not quite right; we should instead be using `clang_getCursorKind`. For example, this tells us that we are dealing with an enum declaration (which happens to be reported as type enum); this matters in some cases, for example, a macro definition does not have any associated type (reported as "invalid"), but is reported as cursor kind "macro definition".
edsko
force-pushed
the
edsko/cursor-kind
branch
from
70ef943 to
eb7cf43
Compare
phadej
reviewed
Sep 4, 2024
| "PACKED_C" :: "Int" | ||
| "macro definition" "ENUMS_H" :: "Invalid" | ||
| "EnumDecl" "first" :: "Enum" | ||
| "EnumConstantDecl" "FIRST1" :: "Int" |
There was a problem hiding this comment.
does this mean that we don't need to check parent when getting enum value, checking the kind of the cursor is enough?
There was a problem hiding this comment.
Ah, yes, well-spotted. Will fix.
In order to do the error check we need to check the cursor kind; previously we were (incorrectly?) looking at the _type_ kind, which for an enum member will just report `Int`, which isn't particularly informative. We therefore looked at the type kind of the _parent_, but instead we should just look at the kind of the _cursor_ (which will be `EnumConstantDecl`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
clang_getCursorTypeto determine what kind of AST element we were dealing with, but that's not quite right; we should instead be usingclang_getCursorKind. For example, this tells us that we are dealing with an enum declaration (which happens to be reported as type enum); this matters in some cases, for example, a macro definition does not have any associated type (reported as "invalid"), but is reported as cursor kind "macro definition".