Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): show external errors without requiring debugging #335

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

wellwelwel
Copy link
Owner

Now when an error occurs external to assert, it will be displayed without the need to use the debug option.

  • The debug option continues to be useful for displaying logs external to Poku, such as console.log, etc.

@wellwelwel wellwelwel added the cli label Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.72%. Comparing base (290c6b4) to head (d291ec6).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   94.75%   94.72%   -0.04%     
==========================================
  Files          30       30              
  Lines        2480     2463      -17     
  Branches      354      354              
==========================================
- Hits         2350     2333      -17     
  Misses        128      128              
  Partials        2        2              
Flag Coverage Δ
linux-parallel ?
linux-parallel-options ?
linux-sequential 93.05% <100.00%> (-0.05%) ⬇️
linux-sequential-options ?
osx-parallel ?
osx-parallel-options ?
osx-sequential 93.05% <100.00%> (-0.05%) ⬇️
osx-sequential-options 93.13% <100.00%> (-0.05%) ⬇️
windows-parallel 93.99% <100.00%> (-0.05%) ⬇️
windows-parallel-options 94.11% <100.00%> (-0.05%) ⬇️
windows-sequential 92.52% <100.00%> (-0.06%) ⬇️
windows-sequential-options 92.61% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel marked this pull request as ready for review June 5, 2024 19:57
@wellwelwel wellwelwel merged commit f954089 into main Jun 5, 2024
37 checks passed
@wellwelwel wellwelwel deleted the improve-failures branch June 5, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant