Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary await #942

Merged
merged 2 commits into from
Feb 5, 2025
Merged

refactor: remove unnecessary await #942

merged 2 commits into from
Feb 5, 2025

Conversation

wellwelwel
Copy link
Owner

@wellwelwel wellwelwel commented Feb 5, 2025

Since the await is already used by the caller of each respective method, we can just return the Promise directly.

Let's see if it affects the benchmark in any way (nope).

@wellwelwel wellwelwel marked this pull request as ready for review February 5, 2025 03:42
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.27%. Comparing base (75083c5) to head (a58539d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #942      +/-   ##
==========================================
+ Coverage   99.23%   99.27%   +0.04%     
==========================================
  Files          47       47              
  Lines        2349     2347       -2     
  Branches       13       13              
==========================================
- Hits         2331     2330       -1     
  Misses          8        8              
+ Partials       10        9       -1     
Flag Coverage Δ
linux 99.14% <100.00%> (-0.01%) ⬇️
osx 99.19% <100.00%> (?)
windows 97.99% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel merged commit 267624e into main Feb 5, 2025
21 checks passed
@wellwelwel wellwelwel deleted the await branch February 5, 2025 03:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant