✨ feat(theme-switcher)!: respect theme_default
when JS is enabled
#224
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you had
default_theme
set and want the colourscheme to follow user OS preferences (as it did before this PR), setdefault_theme = ""
or comment it out on yourconfig.toml
.Summary
This PR ensures the
default_theme
specified inconfig.toml
is respected on first load.Related issue
Resolves #223.
Changes
initializeTheme
to prioritize thedefault_theme
setting from theconfig.toml
file, ensuring that this setting is respected on the first website load.themeSwitcher
script to include adefaultTheme
variable and updated the theme application logic to align with the new initial theme setting approach.themeSwitcher
script's functionality for resetting the theme, now prioritizing thedefault_theme
setting.Accessibility
This update maintains the existing accessibility features, including semantic HTML, ARIA attributes, and keyboard navigation compatibility.
Type of change
Checklist
theme.toml
with a sane default for the feature.config.toml
comments.theme.toml
comments.