🐛 fix: prevent background overflow on link hover #226
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses a UI bug where additional space was highlighted when hovering over a hyperlink that starts at a newline or crosses a newline boundary.
The issue was fixed by adding a
max-width
to the::before
pseudo-element for links. I'm not sure why this works, but it does.Related issue
Fixes #225 and #184.
Changes
The
max-width
property has been added to the::before
pseudo-element for anchor tags to ensure proper rendering of the hover effect across Webkit and Chromium-based browsers.Additionally, I simplified the CSS. But the bugfix is just the
max-width
.With this change, on Chromium and WebKit browsers, multi-line links render as though the
::before
element were absent.Firefox rendering remains identical.
Accessibility
No changes.
Screenshots
Before:
After:
Type of change
Checklist
theme.toml
with a sane default for the featureconfig.toml
commentstheme.toml
comments