Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for self.generic_visit(node) being called in AST visitors. #1660

Merged
merged 5 commits into from
Oct 11, 2020

Conversation

lensvol
Copy link
Collaborator

@lensvol lensvol commented Oct 11, 2020

I have made things!

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Related issues

Closes #1363.

I've decided not to create tests for that one, since it would be a disproportionally bigger amount of work in my opinion. Open to discussion on that one.

🙏 Please, if you or your company is finding wemake-python-styleguide valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/wemake-python-styleguide. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.

@sobolevn
Copy link
Member

See python-poetry/poetry#3140

@lensvol lensvol changed the title Meta visit check Check for self.generic_visit(node) being called in AST visitors. Oct 11, 2020
@codecov
Copy link

codecov bot commented Oct 11, 2020

Codecov Report

Merging #1660 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master     #1660    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          101       105     +4     
  Lines         5287      5610   +323     
  Branches      1182      1272    +90     
==========================================
+ Hits          5287      5610   +323     
Impacted Files Coverage Δ
...ython_styleguide/visitors/ast/complexity/counts.py 100.00% <100.00%> (ø)
...thon_styleguide/visitors/ast/complexity/imports.py 100.00% <100.00%> (ø)
wemake_python_styleguide/logic/tree/ifs.py 100.00% <0.00%> (ø)
wemake_python_styleguide/logic/tree/keywords.py 100.00% <0.00%> (ø)
wemake_python_styleguide/logic/tree/variables.py 100.00% <0.00%> (ø)
wemake_python_styleguide/violations/refactoring.py 100.00% <0.00%> (ø)
...emake_python_styleguide/visitors/ast/conditions.py 100.00% <0.00%> (ø)
wemake_python_styleguide/formatter.py 100.00% <0.00%> (ø)
wemake_python_styleguide/version.py 100.00% <0.00%> (ø)
wemake_python_styleguide/checker.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cad16b5...0f69e7d. Read the comment docs.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I knew we have some items missing! Thanks a lot! 👍

@sobolevn sobolevn merged commit 852fe4b into master Oct 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the meta-visit-check branch October 11, 2020 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check that self.generic_visit(node) is on the last line
2 participants