Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace typing.re import #2414

Merged
merged 4 commits into from
May 18, 2022
Merged

Replace typing.re import #2414

merged 4 commits into from
May 18, 2022

Conversation

srittau
Copy link
Contributor

@srittau srittau commented May 18, 2022

typing.re has been deprecated since Python 3.8 and will be removed in Python 3.12. But Pattern can also be imported directly from typing.

Checklist

  • I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
  • I have created at least one test case for the changes I have made
  • I have updated the documentation for the changes I have made
  • I have added my changes to the CHANGELOG.md

Should this have a CHANGELOG entry?

Related issues

python/cpython#92873

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @srittau! Glad to see you here :)

Thanks for the fix.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #2414 (5c700c7) into master (6f12c15) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##            master     #2414   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          120       120           
  Lines         6425      6422    -3     
  Branches      1447      1447           
=========================================
- Hits          6425      6422    -3     
Impacted Files Coverage Δ
wemake_python_styleguide/visitors/ast/builtins.py 100.00% <100.00%> (ø)
...ke_python_styleguide/visitors/tokenize/comments.py 100.00% <100.00%> (ø)
..._python_styleguide/visitors/tokenize/primitives.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f12c15...5c700c7. Read the comment docs.

@sobolevn sobolevn merged commit 9318fed into wemake-services:master May 18, 2022
@srittau srittau deleted the typing-re branch May 18, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants