Issue 3520

[ZhdanovAM72]

I have made things!

Adds a new consistency violation to enforce using if instead of simple two-case match statements with a wildcard _.

• Implemented SimplifiableMatchViolation with code WPS365
• Created SimplifiableMatchVisitor to detect:
  • Exactly two cases
  • Second case is case _:
  • First case uses a simple pattern (e.g. CONST, ENUM.VALUE, 1, or A | B)

Checklist

• I have double checked that there are no unrelated changes in this pull request (old patches, accidental config files, etc)
• I have created at least one test case for the changes I have made
• I have updated the documentation for the changes I have made
• I have added my changes to the CHANGELOG.md

Related issues

Closes #3520

[sobolevn]

Thanks!

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (27093cf) to head (ea5468a).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff            @@
##            master     #3526   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          364       365    +1     
  Lines        12106     12181   +75     
  Branches       827       834    +7     
=========================================
+ Hits         12106     12181   +75     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sobolevn]

Please, also create a new issue that we can also simplify cases like

match x:
    case 1: ...

when there's a match with only 1 case

[sobolevn]

Almost there! Thanks a lot!

[sobolevn]

👍

[sobolevn]

Looks great! Thank you!