Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add endpoint to add and update field value #493

Merged
merged 6 commits into from
Jan 29, 2025

Conversation

lucaslinhares
Copy link

No description provided.

@lucaslinhares lucaslinhares force-pushed the feature/internal-endpoint-update-contact-field branch from c4a745e to 739feb7 Compare January 28, 2025 17:45
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.12%. Comparing base (e4bfc8d) to head (9350ec5).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #493   +/-   ##
=======================================
  Coverage   99.12%   99.12%           
=======================================
  Files         566      566           
  Lines       29208    29263   +55     
=======================================
+ Hits        28953    29008   +55     
  Misses        255      255           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


contact.update_fields(fields_to_update)

mods = contact.update_fields(fields_to_update)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this being called 2 times in a row?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, fixed!

Base automatically changed from feature/internal-endpoint-create-contact-field to main January 29, 2025 20:46
@lucaslinhares lucaslinhares force-pushed the feature/internal-endpoint-update-contact-field branch from 58ba543 to 9350ec5 Compare January 29, 2025 21:09
@lucaslinhares lucaslinhares merged commit 1b6e45c into main Jan 29, 2025
8 checks passed
@lucaslinhares lucaslinhares deleted the feature/internal-endpoint-update-contact-field branch January 29, 2025 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants