Module2 example1 #36
Open
Module2 example1 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This branch uses docker for it's builds.
lock in version of node to 8.x
Hi Folks, thanks to one of our learners, they reported an issue when running probot-hello in the `Develop locally` section. It was producing the error:
```
Error: The contents of `PRIVATE_KEY` could not be validated. Please check to ensure you have copied the contents of the .pem file correctly.
at findPrivateKey (/home/node/probot-hello-dev/node_modules/probot/lib/private-key.js:37:15)
```
Turns out that setting PRIVATE_KEY to none no longer resolves to a false statement in probot lib's check for a private key. Instead we can now simply set the environment value to an empty value and have it processed properly in the probot lib to check for no private key and skip that check for local dev.
Apologies if this slowed anyone down.
Removing none to unset PRIVATE_KEY
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.