Add tests for math lib #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks awesome!👍 Please keep it up! |
|
I've added tests for math lib APIs except the following:
|
Limitation of the current implementation: If the expected value is 1 or -1, the test doesn't reject results greater than 1 or less than -1 respectively.
In a computing environment where +0 and -0 are different, it's expected that atan2(+0, -x) = +pi, atan2(-0, -x) = -pi. In a computing environment where there's only one unsigned zero, it's expected that atan2(0, -x) = +pi. JavaScript (and the majority if not all of runtime environments wenyan currently run in) has signed zeros, but currently there's no portable way to differentiate +0 and -0 in wenyan. As a result, the math library currently is not able to place +0 and -0 on different branches for functions like atan2. This commit modifies the test for atan2 so that it accepts both atan2(-0, -x) = -pi and atan2(-0, -x) = pi.
statementreply
force-pushed
the
test-math
branch
from
b480c01 to
c5e1372
Compare
|
Just for curious. How you do get those test cases? 😲 |
|
|
Thanks so much for the tests! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.