Skip to content

Commit

Permalink
logictest: skip distsql_tenant_locality under duress
Browse files Browse the repository at this point in the history
Flaky test: see cockroachdb#118627

Epic: None
Release note: None
  • Loading branch information
rickystewart authored and wenyihu6 committed Feb 21, 2024
1 parent 2aa661e commit ac0ac53
Show file tree
Hide file tree
Showing 13 changed files with 41 additions and 5 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pkg/ccl/logictestccl/tests/3node-tenant/generated_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pkg/cmd/generate-logictest/templates.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ func runCCLLogicTest(t *testing.T, file string) {
{{- if .ExecBuildLogicTest -}}
func runExecBuildLogicTest(t *testing.T, file string) {
defer sql.TestingOverrideExplainEnvVersion("CockroachDB execbuilder test version")()
if file == "distsql_tenant_locality" {
skip.UnderDuressWithIssue(t, 118627)
}
skip.UnderDeadlock(t, "times out and/or hangs")
serverArgs := logictest.TestServerArgs{
DisableWorkmemRandomization: true,{{ if .ForceProductionValues }}
Expand Down
10 changes: 5 additions & 5 deletions pkg/sql/opt/exec/execbuilder/testdata/distsql_tenant_locality
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,12 @@ statement ok
SELECT * FROM t

# Check sql instance locality in the secondary tenant.
query ITB retry
SELECT id, locality, crdb_internal.sql_liveness_is_alive(session_id) FROM system.sql_instances WHERE locality IS NOT NULL ORDER BY id
query IT
SELECT id, locality FROM system.sql_instances WHERE locality IS NOT NULL ORDER BY id
----
1 {"Tiers": "region=test"} true
2 {"Tiers": "region=test1"} true
3 {"Tiers": "region=test2"} true
1 {"Tiers": "region=test"}
2 {"Tiers": "region=test1"}
3 {"Tiers": "region=test2"}

# Ensure that we plan TableReaders in the regions according to the leaseholder
# of each range, namely we want
Expand Down
3 changes: 3 additions & 0 deletions pkg/sql/opt/exec/execbuilder/tests/5node/generated_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pkg/sql/opt/exec/execbuilder/tests/fakedist/generated_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 3 additions & 0 deletions pkg/sql/opt/exec/execbuilder/tests/local/generated_test.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit ac0ac53

Please sign in to comment.