Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update definitions list #160

Merged
merged 16 commits into from
May 27, 2019
Merged

Conversation

GQuirino
Copy link
Contributor

@GQuirino GQuirino commented May 17, 2019

update list of domains
following Public Suffix List

@weppos
Copy link
Owner

weppos commented May 21, 2019

@GQuirino how did you update the list? Did you update it manually?

@GQuirino
Copy link
Contributor Author

GQuirino commented May 22, 2019

@weppos yes, i did it manually. there is another way to do it?

@weppos
Copy link
Owner

weppos commented May 22, 2019

There is a rake task.

task :"update-list" do

@codecov-io
Copy link

Codecov Report

Merging #160 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #160   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files          11       11           
  Lines         619      619           
=======================================
  Hits          618      618           
  Misses          1        1

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2803479...ae75963. Read the comment docs.

@GQuirino
Copy link
Contributor Author

@weppos now updated by task, thanks for the heads up.

@weppos weppos self-assigned this May 27, 2019
@weppos weppos merged commit 245836e into weppos:master May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants