Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce gem size #258

Merged
merged 1 commit into from
Aug 31, 2023
Merged

Reduce gem size #258

merged 1 commit into from
Aug 31, 2023

Conversation

ybiquitous
Copy link
Contributor

The current published gem includes test files or build files that are actually unneeded.
This change removes such files from a published gem.

In addition, this removes test_files from the gemspec since it is no longer supported.
See https://guides.rubygems.org/specification-reference/

Verification:

$ bundle exec rake build && gem unpack pkg/*.gem
public_suffix 5.0.3 built to pkg/public_suffix-5.0.3.gem.
Unpacked gem: '/Users/masafumi.koba/git/ybiquitous/publicsuffix-ruby/public_suffix-5.0.3'

$ tree public_suffix-*
public_suffix-5.0.3/
├── .yardopts
├── 2.0-Upgrade.md
├── CHANGELOG.md
├── LICENSE.txt
├── README.md
├── SECURITY.md
├── data/
│   └── list.txt
└── lib/
    ├── public_suffix/
    │   ├── domain.rb
    │   ├── errors.rb
    │   ├── list.rb
    │   ├── rule.rb
    │   └── version.rb
    └── public_suffix.rb

4 directories, 13 files

The current published gem includes test files or build files that are actually unneeded.
This change removes such files from a published gem.

In addition, this removes `test_files` from the gemspec since it is no longer supported.
See https://guides.rubygems.org/specification-reference/

Verification:

```console
$ bundle exec rake build && gem unpack pkg/*.gem
public_suffix 5.0.3 built to pkg/public_suffix-5.0.3.gem.
Unpacked gem: '/Users/masafumi.koba/git/ybiquitous/publicsuffix-ruby/public_suffix-5.0.3'

$ tree public_suffix-*
public_suffix-5.0.3/
├── .yardopts
├── 2.0-Upgrade.md
├── CHANGELOG.md
├── LICENSE.txt
├── README.md
├── SECURITY.md
├── data/
│   └── list.txt
└── lib/
    ├── public_suffix/
    │   ├── domain.rb
    │   ├── errors.rb
    │   ├── list.rb
    │   ├── rule.rb
    │   └── version.rb
    └── public_suffix.rb

4 directories, 13 files
```
@weppos weppos self-assigned this Aug 31, 2023
@weppos
Copy link
Owner

weppos commented Aug 31, 2023

Thanks!

@weppos weppos merged commit 4883fbd into weppos:main Aug 31, 2023
5 checks passed
@ybiquitous ybiquitous deleted the reduce-gem-size branch August 31, 2023 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants