Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/2.1.15/numeric input step #90

Merged
merged 2 commits into from
May 2, 2024

Conversation

tiller1010
Copy link
Member

@tiller1010 tiller1010 commented May 1, 2024

https://werkbotstudios.teamwork.com/app/tasks/34997511

Summary

  • code styles in form.js
  • respect step attribute for numeric field buttons
  • respect min and max attributes for numeric field buttons

Testing Steps

  • test with the xmc calculator (you may want to set a max on the NumericField in CalculatorPageController) https://github.com/werkbot/xmc/pull/52
  • confirm the step attribute is respected, should increment by 5
  • confirm the min and max attributes are respected

Git Flow

  • DO NOT delete "release/*" or "hotfix/*" branches after merging a PR. These are used to publish the next release, and they are deleted automatically.
  • "Squash and merge" is good on "feature/*" into "develop"
  • "Create a merge commit" is good on "release/*" or "hotfix/*" into "main"
  • With npm repositories, the version number must be incremented manually, before merging the release.

Copy link
Member

@aletail aletail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@tiller1010 tiller1010 merged commit ec66da6 into main May 2, 2024
1 check passed
@github-actions github-actions bot deleted the hotfix/2.1.15/numeric-input-step branch May 2, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants