Added class option for labels to appear above their field #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added class option to display labels above the form fields
tiller1010
requested changes
Oct 31, 2024
There was a problem hiding this comment.
This looks like it should be tagged as minor instead of patch since it adds new functionality.
I had some issues with vite not showing the updates after a npm update/build/copy
It could be that you have to run the yarn container first, if you have the vite container running.
docs/en/form.md
Outdated
| @@ -100,3 +100,6 @@ $component-form-text-with-button-properties: ( | |||
| ## Form Process Animation | |||
| When a form is submitted all fields are disabled including the submit button. An animated icon is added next to the submit button as well. | |||
| You must opt-in for this to take effect, the form element must contain the following class: `fw-form-process-event` as well as the `fw-form` class. | |||
|
|
|||
| ## Label placements | |||
| By default, labels are placed inside the input box. To change this, simply add the `fw-form-label-above` class alongside the `fw-form class`. This adjustment moves labels above the fields, eliminating any animation when a field gains or loses focus. | |||
There was a problem hiding this comment.
The backtick on the fw-form includes "class", so it appears as "fw-form class" instead of "fw-form class".
| transform: none; | ||
| } | ||
| } | ||
| textarea{ |
There was a problem hiding this comment.
This should be an input selector.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://werkbotstudios.teamwork.com/app/tasks/36275863
Summary
Testing Steps
fw-form-label-aboveclass to forms (UserFormExtension in xmc)Issues/Concerns
Git Flow