Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude Docker Volumes from Storage Check #6

Merged
merged 6 commits into from
Apr 15, 2020
Merged

Exclude Docker Volumes from Storage Check #6

merged 6 commits into from
Apr 15, 2020

Conversation

Byolock
Copy link
Contributor

@Byolock Byolock commented Apr 14, 2020

Fixes #5

Byolock added 5 commits April 14, 2020 14:54
@Byolock
exclude docker volumes
3967d4e
@Byolock
added missing import
2301589
@Byolock
Update check_synology.py
fc5546c
@Byolock
Update check_synology.py
1a946c6
@Byolock
additional filter
476d844 
possible volume names are 
/volume'X'/@docker/id/'something'/
and
/volume'X'/@docker <- this needs another regex check

alternative : 
look for "/volume.+/@DocKe.+"

Might lead to false positives?
@wernerfred
Copy link
Owner

Thanks!
I will try it in my lab and give feedback

wernerfred
wernerfred requested changes Apr 14, 2020
View reviewed changes
Copy link
Owner

@wernerfred wernerfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please validate this solution with your setup and if it does not cause any new issue update the pull request that i can merge.

check_synology.py Outdated Show resolved Hide resolved
@wernerfred wernerfred added the waiting for contributor action Waiting for the contributor to respond label Apr 14, 2020
@wernerfred wernerfred removed the waiting for contributor action Waiting for the contributor to respond label Apr 15, 2020
@wernerfred wernerfred merged commit 9c13749 into wernerfred:master Apr 15, 2020
@wernerfred
Copy link
Owner

@all-contributors add @Byolock for code, bug

@allcontributors allcontributors bot mentioned this pull request Jul 8, 2021
Merged
@allcontributors
Copy link
Contributor

@wernerfred

I've put up a pull request to add @Byolock! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wernerfred wernerfred wernerfred requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Zero Division Error with mode Storage & Docker Container Volumes
2 participants
@Byolock @wernerfred