Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Node 8 breaks plugin #23

Closed
wernerglinka opened this issue Apr 18, 2018 · 6 comments
Closed

Upgrade to Node 8 breaks plugin #23

wernerglinka opened this issue Apr 18, 2018 · 6 comments

Comments

@wernerglinka
Copy link
Owner

wernerglinka commented Apr 18, 2018

After upgrading node to version 8 my build process breaks.

TypeError: Cannot read property 'tokenizePlaceholders' of undefined
    at /Users/.../node_modules/prismjs/components/prism-php.js:121:40
    at Object.run (/Users/.../node_modules/prismjs/prism.js:456:5)
    at Object.highlight (/Users/.../node_modules/prismjs/prism.js:287:11)
    at Object.<anonymous> (/Users/.../node_modules/metalsmith-prism/lib/index.js:94:41)
    at initialize.exports.each (/Users/.../node_modules/cheerio/lib/api/traversing.js:300:24)
    at _.each (/Users/.../node_modules/metalsmith-prism/lib/index.js:62:17)
    at /Users/.../node_modules/metalsmith-prism/node_modules/lodash/lodash.js:4917:15
    at baseForOwn (/Users/.../node_modules/metalsmith-prism/node_modules/lodash/lodash.js:3002:24)
    at /Users/.../node_modules/metalsmith-prism/node_modules/lodash/lodash.js:4886:18
    at Function.forEach (/Users/.../node_modules/metalsmith-prism/node_modules/lodash/lodash.js:9334:14)
    at Ware.<anonymous> (/Users/.../node_modules/metalsmith-prism/lib/index.js:51:7)
    at Ware.<anonymous> (/Users/.../node_modules/wrap-fn/index.js:45:19)
    at next (/Users/.../node_modules/ware/lib/index.js:85:20)
    at /Users/.../node_modules/wrap-fn/index.js:121:18
    at /Users/.../node_modules/metalsmith-in-place/node_modules/async/lib/async.js:52:16
    at done (/Users/.../node_modules/metalsmith-in-place/node_modules/async/lib/async.js:246:17)

Any idea what this could be? Any pointer is appreciated.

@wernerglinka
Copy link
Owner Author

Yes, I have found those but how do I deal with this at this plugin level?

@robmcguinness
Copy link
Contributor

@robmcguinness
Copy link
Contributor

Let me know if that helps.

@wernerglinka
Copy link
Owner Author

wernerglinka commented May 12, 2018 via email

@robmcguinness
Copy link
Contributor

robmcguinness commented May 14, 2018

(note to self) Example fix for php syntax: PrismJS/prism#1400 (comment) or PrismJS/prism#1359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants