Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customize the color of specific object types in python #218 #223

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Customize the color of specific object types in python #218 #223

merged 3 commits into from
Apr 11, 2023

Conversation

SmitAkbari26
Copy link
Contributor

No description provided.

@SmitAkbari26 SmitAkbari26 reopened this Mar 25, 2023
@SmitAkbari26
Copy link
Contributor Author

Hello, @wesbos Smit here.
Please check pull request for #218 issue and let me know if i make it wrong.
Thank you.

@palashmon
Copy link
Collaborator

Hi @SmitAkbari26 ,
If possible, could you please share a screenshot of how the code looks now, after the new changes?
Previously it used to look like this:

Regards!

@SmitAkbari26
Copy link
Contributor Author

Sure, Here it is

image

if need any changes in that let me know

palashmon
palashmon reviewed Apr 11, 2023
View reviewed changes
theme/cobalt2.json Outdated Show resolved Hide resolved
@SmitAkbari26
Copy link
Contributor Author

Please check: commit 2676634

@palashmon
Copy link
Collaborator

Thank you for your contribution!

@palashmon palashmon merged commit be43d3c into wesbos:master Apr 11, 2023
@palashmon palashmon mentioned this pull request Apr 11, 2023
Closed
@SmitAkbari26
Copy link
Contributor Author

appreciated

@rennsax
Copy link
Contributor

rennsax commented Jul 25, 2023 •
edited
Loading

Hello @SmitAkbari26 , I find this merge make self parameter lose its highlight when semantic tokens are enabled. Maybe more scopes should be considered.

Before:
image

After:
image

Python language server: Provided by the extension Pylance

@rennsax rennsax mentioned this pull request Jul 26, 2023
Open
@SmitAkbari26
Copy link
Contributor Author

@Eitheages I solve self parameter issue wait to merge new pull request which i created. I hope i solve issue which you want.

rennsax added a commit to rennsax/cobalt2-vscode that referenced this pull request Aug 20, 2023
@rennsax
Revert "Merge pull request wesbos#223 from SmitAkbari26/master"
c3b0063 
This reverts commit be43d3c, reversing
changes made to 280f561.
This was referenced Aug 20, 2023
Open
Open
rennsax added a commit to rennsax/cobalt2-vscode that referenced this pull request Feb 27, 2024
@rennsax
Revert "Merge pull request wesbos#223 from SmitAkbari26/master"
6b357d5 
This reverts commit be43d3c, reversing
changes made to 280f561.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palashmon palashmon palashmon left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SmitAkbari26 @palashmon @rennsax