feat: GROWI Questionnaire #7316
Conversation
…' into feat/110280-112131-questionnaire-order-save
…stionnaire-order-periodically feat: 110268 111686 get questionnaire order periodically
…/110280-112131-112133-questionnaire-order-save
…growi into feat/110280-112131-112133-questionnaire-order-save
…uestionnaire-files-to-features
…stionnaire-files-to-features Imprv/121200 121334 move all questionnaire files to features
| @@ -9,15 +9,23 @@ import { apiv3Post } from '~/client/util/apiv3-client'; | |||
| import { toastError } from '~/client/util/toastr'; | |||
| import { useCurrentUser } from '~/stores/context'; | |||
|
|
|||
| import ProactiveQuestionnaireModal from '../../features/questionnaire/client/components/ProactiveQuestionnaireModal'; | |||
There was a problem hiding this comment.
~/features/...にして- next/dynamic 使って
| @@ -22,6 +22,7 @@ import superjson from 'superjson'; | |||
| import { useCurrentGrowiLayoutFluidClassName, useEditorModeClassName } from '~/client/services/layout'; | |||
| import { PageView } from '~/components/Page/PageView'; | |||
| import { DrawioViewerScript } from '~/components/Script/DrawioViewerScript'; | |||
| import QuestionnaireModalManager from '~/features/questionnaire/client/components/QuestionnaireModalManager'; | |||
apps/app/src/utils/sleep.ts
Outdated
There was a problem hiding this comment.
これあんまり汎用化したくないので、このファイルは消して使う箇所で定義して
There was a problem hiding this comment.
questioinnaire-cron.ts でのみ使用していたのでこのクラス内で定義しました。
| background-color: var(--primary) !important; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
features の下に定義して @use で入れられないかな
この辺参考に
https://lunalunadesign.net/2022/09/2895/
ちょっとやってみて時間がかかるようだったら諦めていい。
There was a problem hiding this comment.
apps/app/src/stores/modal.tsx
Outdated
| return swrResponse.mutate({ openedQuestionnaireId: null }); | ||
| }, | ||
| }; | ||
| }; |
| key: 'app:deploymentType', | ||
| type: ValueType.STRING, | ||
| default: null, | ||
| }, |
There was a problem hiding this comment.
SERVICE_TYPE、DEPLOYMENT_TYPE は本体情報なのでそのままにしました。
GROWI_QUESTIONNAIRE_SERVER_ORIGIN は key名とともに QUESTIONNAIRE_SERVER_ORIGIN に修正
| logger.error(err); | ||
| return res.apiv3Err({ error: 'Failed to update questionnaire settings.' }); | ||
| } | ||
| }); |
There was a problem hiding this comment.
features の中に admin 用の routes ファイル作ってそこに移して router.use で読み込めないか
かえって複雑になりそうだったら見送ってよい
There was a problem hiding this comment.
| return res.apiv3Err(new ErrorV3(msg, 'update-questionnaire-settings-failed')); | ||
| } | ||
|
|
||
| }); |
There was a problem hiding this comment.
features の中に routes ファイル作ってそこに移して router.use で読み込めないか
かえって複雑になりそうだったら見送ってよい
There was a problem hiding this comment.
|
reg-suit detected visual differences. Check this report, and review them. 🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴 What do the circles mean?The number of circles represent the number of changed images.🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items How can I change the check status?If reviewers approve this PR, the reg context status will be green automatically. |
task: https://redmine.weseek.co.jp/issues/120949