feat: Update bookmarks tree move to root features #7586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jam411
commented
Apr 20, 2023
There was a problem hiding this comment.
MenuItemType を新しく作成したので forceHideMenuItems に追加対応しました。
PageItemControl
-BookmarkItem
- bookmark のみで使用. 修正不要
-BookmarkList
- bookmark のみで使用. 修正不要
-SubNavButtons
- ★list へ push で対応
-PageListItemL
- IdenticalPathPage
- ★対応
- PageList
- DescendantsPageListSubstance
- DescendantsPageList
- DescendantsPageListModal
- ★対応
- NotFoundPage
- ★対応
- TrashPageList
- ★対応
- SearchResultList
- SearchResultList
- SearchPageBase
- PrivateLegacyPages
- ★対応
- SearchPage
- ★対応
-Item
- ★対応
jam411
commented
Apr 20, 2023
yuki-takei
requested changes
Apr 20, 2023
…9721-update-dnd-root-move
|
BookmarkFolderMenu 周りは https://redmine.weseek.co.jp/issues/119728 でリファクタリングします。 |
yuki-takei
requested changes
Apr 27, 2023
jam411
commented
Apr 28, 2023
yuki-takei
requested changes
Apr 28, 2023
| export const BookmarkFolderItemControl = (props: BookmarkFolderItemControlProps): JSX.Element => { | ||
| }> = ({ | ||
| children, | ||
| isMoveToRoot, |
There was a problem hiding this comment.
onClickMoveToRoot がセットされているかどうかで代用できるのでは？
代用できないのだとしたら変数名を canMoveToRoot に変更する
added 2 commits
April 28, 2023 11:48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://redmine.weseek.co.jp/issues/119721
Outline
Screenshot