Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Not display page list count badge in trash page #7600

Merged
merged 2 commits into from
Apr 26, 2023

Conversation

yukendev
Copy link
Contributor

@yukendev yukendev commented Apr 24, 2023

https://redmine.weseek.co.jp/issues/120917

スクリーンショット 2023-04-24 10 32 16

やったこと

@yukendev yukendev requested a review from yuki-takei April 24, 2023 01:29
@yukendev yukendev self-assigned this Apr 24, 2023
@yukendev yukendev temporarily deployed to VRT April 24, 2023 01:44 — with GitHub Actions Inactive
@reg-suit
Copy link

reg-suit bot commented Apr 24, 2023

reg-suit detected visual differences.

Check this report, and review them.

🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴🔴

🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵🔵

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@yuki-takei yuki-takei merged commit dde77aa into master Apr 26, 2023
@yuki-takei yuki-takei deleted the fix/120917-fix-pagelist-count-in-trash branch April 26, 2023 09:34
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
@yuki-takei yuki-takei mentioned this pull request May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants