feat: Create ReadOnly user components #7610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-takei
requested changes
Apr 28, 2023
| <i className="icon-fw icon-user-following"></i> {t('user_management.user_table.give_read_only_access')} | ||
| </button> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
管理者も ROM にできるように修正しました。
細かいですが、
Read Only Member でなく Read Only User （日本語では”閲覧ユーザー"）として作ってしまったのですが、
Read Only Member （日本語では "閲覧メンバー" ）の方がよいでしょうか。
|
https://redmine.weseek.co.jp/issues/121257 はこの PR のスコープに入ってるの？ |
はい。この PR に含めました。 |
yuki-takei
requested changes
Apr 28, 2023
| <li> | ||
| {user.readOnly === true && <RemoveReadOnlyMenuItem user={user} />} | ||
| {user.readOnly === false && <GiveReadOnlyButton user={user} />} | ||
| </li> |
There was a problem hiding this comment.
前バージョンからアップグレードしたシステムだと user.readOnly が undefined というケースがある。その場合両方のメニューが表示されないことになってしまうので、三項演算子の方がよさそう。
一方 admin は必ず T/F のどちらかが入っているが、可読性を考慮して書式を揃えてもよい。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task:
https://redmine.weseek.co.jp/issues/121033
https://redmine.weseek.co.jp/issues/121257
https://redmine.weseek.co.jp/issues/121034
Screenshot
バッジ