feat: Add activityEvent for ReadOnly user access actions #7615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 30, 2023 06:23
yuki-takei
requested changes
May 1, 2023
| @@ -1009,6 +1009,8 @@ | |||
| "ADMIN_USERS_DEACTIVATE": "Deactivate user", | |||
| "ADMIN_USERS_GIVE_ADMIN": "Give admin access", | |||
| "ADMIN_USERS_REMOVE_ADMIN": "Remove admin access", | |||
| "ADMIN_USERS_GIVE_READ_ONLY": "Give read only access", | |||
| "ADMIN_USERS_REMOVE_READ_ONLY": "Remove read only access", | |||
There was a problem hiding this comment.
今更って感じは否めないが、give/remove って変な感じがする。。
再考をお願いしたい。API エンドポイントもそうなってると思うので、最終的には変えたい。後続タスクでOK。
There was a problem hiding this comment.
| @@ -1017,6 +1017,8 @@ | |||
| "ADMIN_USERS_DEACTIVATE": "ユーザーを停止する", | |||
| "ADMIN_USERS_GIVE_ADMIN": "管理者にする", | |||
| "ADMIN_USERS_REMOVE_ADMIN": "管理者から外す", | |||
| "ADMIN_USERS_GIVE_READ_ONLY": "閲覧ユーザーにする", | |||
| "ADMIN_USERS_REMOVE_READ_ONLY": "閲覧ユーザーから外す", | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
英語「Read Only」日本語「閲覧のみ」にしてアクセス権としました。
https://wsgrowi.slack.com/archives/C0111HG81GB/p1683537245035329
jam411
deleted the
feat/120698-121247-add-activity-event-for-read-only-user
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task: https://redmine.weseek.co.jp/issues/121247
Screenshot